Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Corrections #5496

Merged
merged 11 commits into from
Jan 2, 2024
Merged

Documentation Corrections #5496

merged 11 commits into from
Jan 2, 2024

Conversation

joaolago1113
Copy link
Contributor

This PR addresses minor typos and grammatical errors in various documentation files. These changes aim to enhance readability and ensure accuracy in the documentation.

Changes

  • ADR 026: Fixed typo ('identitical' to 'identical').
  • Channel Upgradability Requirements: Corrected grammatical errors ('has been flushed' to 'have been flushed', 'permissionlesly' to 'permissionlessly').
  • ADR 025: Fixed typo ('chanenlID' to 'channelID').
  • ADR 002: Grammatical corrections ('released during with the' to 'released during the', 'lets' to 'let's').
  • ADR 001: Typo fix ('addressed' to 'addresses').
  • Release Management: Corrected label name ('backport-to-v1.0x' to 'backport-to-v1.0.x').
  • Project Structure: Verb agreement fix ('implement' to 'implements').
  • ADR 027 (Cosmos SDK section): Typo correction ('current' to 'currently').
  • ADR 026 Description: Typo fix ('mechansisms' to 'mechanisms').
  • E2E Tests Section: Corrected tag descriptions for CHAIN_A_TAG and CHAIN_B_TAG.

@joaolago1113
Fix typo in 'Running tests with custom images' section, swap descript…
823cfe9 
…ions for CHAIN_A_TAG and CHAIN_B_TAG
@joaolago1113
Fix typo in ADR 026 description: change 'mechansisms' to 'mechanisms'
9cb1c3c
@joaolago1113
fix: correct typo in Cosmos SDK section, change 'current' to 'currently'
4c9d229
@joaolago1113
Fix typo in documentation: change 'implement' to 'implements'
01e31a1
@joaolago1113
Fix typo in label name from backport-to-v1.0x to backport-to-v1.0.x
968346b
@joaolago1113
Fix typo in IBC spec documentation: Change 'addressed' to 'addresses'
2cc0719
@joaolago1113
Fix grammatical errors in documentation: correct 'released during wit…
9aa414a 
…h the' to 'released during the' and change 'lets' to 'let's' in ADR 002
@joaolago1113
Fix typo: change 'chanenlID' to 'channelID'
fecdf02
@joaolago1113
Fix grammatical errors in documentation: change 'has been flushed' to…
4bb1b55 
… 'have been flushed' and correct spelling of 'permissionlesly' to 'permissionlessly'
@joaolago1113
Fix typo: change 'identitical' to 'identical' in ADR 026 Decision sec…
4d2e053 
…tion
crodriguezvega
crodriguezvega approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches. Thanks, @joaolago1113.

chatton
chatton approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crodriguezvega crodriguezvega merged commit 8711dee into cosmos:main Jan 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatton chatton chatton approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim DimitrisJim is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joaolago1113 @crodriguezvega @chatton